feat(installer): add SSL/HTTPS support to Observability install#90
Merged
Conversation
Add --ssl-cert-file / --ssl-key-file to `obs install`, mirroring the existing TestGen SSL flow. When both are provided, the cert+key are bind-mounted into the UI container and SSL_CERT_FILE/SSL_KEY_FILE are set so its nginx serves HTTPS; the printed service URLs switch to https. All Observability service URLs are proxied through the UI nginx, so applying TLS there covers every displayed endpoint. Align the two products' SSL codepaths: - Validate the cert/key arg pair in the compose step's pre_execute so a mismatch fails fast in the validation phase (parity with TestGen), rather than mid-install. - Record the `used_custom_cert` analytics property as a bool on both products; TestGen previously stored the key-file path string. Add Observability SSL test coverage matching TestGen: arg-pair mismatch aborts, compose contains the SSL env + bind mounts when enabled, and the placeholders are stripped when disabled. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rboni-dk
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --ssl-cert-file / --ssl-key-file to
obs install, mirroring the existing TestGen SSL flow. When both are provided, the cert+key are bind-mounted into the UI container and SSL_CERT_FILE/SSL_KEY_FILE are set so its nginx serves HTTPS; the printed service URLs switch to https. All Observability service URLs are proxied through the UI nginx, so applying TLS there covers every displayed endpoint.Align the two products' SSL codepaths:
used_custom_certanalytics property as a bool on both products; TestGen previously stored the key-file path string.Add Observability SSL test coverage matching TestGen: arg-pair mismatch aborts, compose contains the SSL env + bind mounts when enabled, and the placeholders are stripped when disabled.